[
https://issues.apache.org/jira/browse/HADOOP-13254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371179#comment-15371179
]
Yufei Gu edited comment on HADOOP-13254 at 7/11/16 5:19 PM:
------------------------------------------------------------
This is another option:
If any implementation of {{DiskValidator}} need threads, it should implement
interface {{org.apache.hadoop.service.Service}}. The {{Servcie}} interface
already provides well designed functions for a service like class. Why not
reuse it and keep the {{DiskValidator}} interface simple. Or, make
{{DiskValidator}} extend interface {{Service}}.
was (Author: yufeigu):
This is another option:
If any implementation of {{DiskValidator}} need threads, it should implement
interface {{org.apache.hadoop.service.Service}}. The {{Servcie}} interface
already provides well designed functions for a service like class. Why not
reuse it and keep the {{DiskValidator}} interface simple.
> Create framework for configurable disk checkers
> -----------------------------------------------
>
> Key: HADOOP-13254
> URL: https://issues.apache.org/jira/browse/HADOOP-13254
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Reporter: Yufei Gu
> Assignee: Yufei Gu
> Attachments: HADOOP-13254.001.patch, HADOOP-13254.002.patch,
> HADOOP-13254.003.patch, HADOOP-13254.004.patch, HADOOP-13254.005.patch,
> HADOOP-13254.006.patch, HADOOP-13254.007.patch, HADOOP-13254.008.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
