[
https://issues.apache.org/jira/browse/HADOOP-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372096#comment-15372096
]
Tsuyoshi Ozawa edited comment on HADOOP-13363 at 7/12/16 2:50 AM:
------------------------------------------------------------------
{quote}
This merits a discussion on common-dev for visibility. There was a discussion
before but no conclusion iirc.
{quote}
Sure.
{quote}
What is going to happen when code generated by protoc 2.5 tries to run against
2.6 library? Has anyone tested this? Because thats the metric of how traumatic
this is going to be
{quote}
We must test it before merging it, of course. IIUC, protobuf is wire compatible
between 2.5 and 2.6. I found a test suite which seems useful here:
https://chromium.googlesource.com/external/github.com/google/protobuf/+/master/java/compatibility_tests/README.md
We also need to check code-level compatibility.
was (Author: ozawa):
{quote}
This merits a discussion on common-dev for visibility.
{quote}
Sure.
{quote}
What is going to happen when code generated by protoc 2.5 tries to run against
2.6 library? Has anyone tested this? Because thats the metric of how traumatic
this is going to be
{quote}
We must test it before merging it, of course. IIUC, protobuf is wire compatible
between 2.5 and 2.6. I found a test suite which seems useful here:
https://chromium.googlesource.com/external/github.com/google/protobuf/+/master/java/compatibility_tests/README.md
We also need to check code-level compatibility.
> Upgrade protobuf from 2.5.0 to something newer
> ----------------------------------------------
>
> Key: HADOOP-13363
> URL: https://issues.apache.org/jira/browse/HADOOP-13363
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.0.0-alpha1
> Reporter: Allen Wittenauer
> Attachments: HADOOP-13363.001.patch
>
>
> Standard protobuf 2.5.0 does not work properly on many platforms. (See, for
> example, https://gist.github.com/BennettSmith/7111094 ). In order for us to
> avoid crazy work arounds in the build environment and the fact that 2.5.0 is
> starting to slowly disappear as a standard install-able package for even
> Linux/x86, we need to either upgrade or self bundle or something else.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
