[
https://issues.apache.org/jira/browse/HADOOP-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373692#comment-15373692
]
Xiao Chen commented on HADOOP-13298:
------------------------------------
Hi [~ozawa],
Thanks for working on this!
Unfortunately, this is what I did when hearing from Sean in the email
discussion, and it didn't work.
bq. 2. tar.gz includes LICENSE.txt and NOTICE.txt.
What we need is to include the L&N in the jars (META-INF sections in
particular). This can be verified by running the following script in
hadoop-dist dir after mvn package.
{code}
#!/bin/sh
for f in $(find ./target -name "hadoop*SNAPSHOT.jar"); do
jar -tf $f | grep "LICENSE" > /dev/null
RET1=$?
jar -tf $f | grep "NOTICE" > /dev/null
RET2=$?
if [ $RET1 -ne 0 -a $RET2 -ne 0 ]; then
echo $f "missing LICENSE and NOTICE!";
elif [ $RET1 -ne 0 ]; then
echo $f "missing LICENSE!";
elif [ $RET2 -ne 0 ]; then
echo $f "missing NOTICE!";
else
echo $f "is ok";
fi
done
{code}
The L&Ns are no longer copied into the jar with this change. :(
> Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
> -----------------------------------------------------------------------------
>
> Key: HADOOP-13298
> URL: https://issues.apache.org/jira/browse/HADOOP-13298
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
> Reporter: Xiao Chen
> Assignee: Sean Busbey
> Priority: Minor
> Attachments: HADOOP-13298.001.patch, HADOOP-13298.002.patch
>
>
> After HADOOP-12893, an extra copy of LICENSE.txt and NOTICE.txt exists in
> {{hadoop-build-tools/src/main/resources/META-INF/}} after build. We should
> remove it and do it the maven way.
> Details in
> https://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201606.mbox/%3CCAFS=wjwx8nmqj6fzxuzzbwraeoggfr+_ywl_mkfp4lnuxpg...@mail.gmail.com%3E
> Thanks [[email protected]] for raising the issue and [~busbey] for offering
> the help!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
