[ 
https://issues.apache.org/jira/browse/HADOOP-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15378342#comment-15378342
 ] 

Xiao Chen commented on HADOOP-13298:
------------------------------------

Thanks for the new rev, [~ozawa].
My apologies to let patch 3 slip, my guess is I somehow verified in a wrong 
dir..

I built using patch 4 (by {{mvn package}}), but the jar still seem to have no 
L&N. I used the exact scripts in HADOOP-13374, and also manually spot checked a 
jar.

BTW, I made this change to pass compilation locally. Not sure why jenkins 
didn't complain about it.
{code:xml}
<directory>../</directory>
<includes>LICENSE.txt,NOTICE.txt</includes>
{code}
to
{code:xml}
<directory>../</directory>
<includes>
  <include>NOTICE.txt</include>
  <include>LICENSE.txt</include>
</includes>
{code}

> Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-13298
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13298
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>            Reporter: Xiao Chen
>            Assignee: Sean Busbey
>            Priority: Minor
>         Attachments: HADOOP-13298.001.patch, HADOOP-13298.002.patch, 
> HADOOP-13298.003.patch, HADOOP-13298.004.patch
>
>
> After HADOOP-12893, an extra copy of LICENSE.txt and NOTICE.txt exists in 
> {{hadoop-build-tools/src/main/resources/META-INF/}} after build. We should 
> remove it and do it the maven way.
> Details in 
> https://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201606.mbox/%3CCAFS=wjwx8nmqj6fzxuzzbwraeoggfr+_ywl_mkfp4lnuxpg...@mail.gmail.com%3E
> Thanks [[email protected]] for raising the issue and [~busbey] for offering 
> the help!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to