[
https://issues.apache.org/jira/browse/HADOOP-11601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379894#comment-15379894
]
Daniel Templeton commented on HADOOP-11601:
-------------------------------------------
Finally! :) Looks good. My last comment is on this code:
{code}
if (!fs.exists(path)) {
if (isSupported(IS_BLOBSTORE)) {
// object store: downgrade to a skip so that the failure is visible
// in test results
skip( "Filesystem is an object store and newly created files are not
immediately visible");
}
assertPathExists("expected path to be visible before file closed",
path);
}
{code}
Since the {{assertPathExists()}} call will check {{!fs.exists(path)}}, this
seems redundant. You can get the same behavior with fewer checks with:
{code}
if (isSupported(IS_BLOBSTORE) && !fs.exists(path)) {
// object store: downgrade to a skip so that the failure is visible
// in test results
skip( "Filesystem is an object store and newly created files are not
immediately visible");
}
assertPathExists("expected path to be visible before file closed",
path);
{code}
> Enhance FS spec & tests to mandate FileStatus.getBlocksize() >0 for non-empty
> files
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-11601
> URL: https://issues.apache.org/jira/browse/HADOOP-11601
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs, test
> Affects Versions: 2.6.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Attachments: HADOOP-11601-001.patch, HADOOP-11601-002.patch,
> HADOOP-11601-003.patch, HADOOP-11601-004.patch, HADOOP-11601-005.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> HADOOP-11584 has shown that the contract tests are not validating that
> {{FileStatus.getBlocksize()}} must be >0 for any analytics jobs to partition
> workload correctly.
> Clarify in text and add test to do this. Test MUST be designed to work
> against eventually consistent filesystems where {{getFileStatus()}} may not
> be immediately visible, by retrying operation if FS declares it is an object
> store.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
