[
https://issues.apache.org/jira/browse/HADOOP-13354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15395035#comment-15395035
]
Sivaguru Sankaridurg edited comment on HADOOP-13354 at 7/27/16 4:55 AM:
------------------------------------------------------------------------
Hi [~cnauroth],
Thank you for reviewing the code changes.
The block ID generation logic in {code}BlockBlobAppendStream{code} needed to
change in order to match the logic in 4.2.0.
The check for blockIdPrefix was just defensive programming.
The constructor calls <code>setBlocksCountAndBlockIdPrefix</code> today.
This check would bring to fore, the implicit assumption in the code that
<code>setBlocksCountAndBlockIdPrefix</code> needs to be called before
<code>generateBlockId</code>; if the code were to be moved around later.
Another way that I think about it, is that <code>generateBlockId</code> uses
<code>this.blockIdPrefix</code>. The check ensures that the input it uses is
initialized before actually using it, independent of the code that actually
initializes the input.
Thanks
Siva
was (Author: sisan...@microsoft.com):
Hi [~cnauroth],
Thank you for reviewing the code changes.
The block ID generation logic in {noformat}BlockBlobAppendStream{noformat}
needed to change in order to match the logic in 4.2.0.
The check for blockIdPrefix was just defensive programming.
The constructor calls <code>setBlocksCountAndBlockIdPrefix</code> today.
This check would bring to fore, the implicit assumption in the code that
<code>setBlocksCountAndBlockIdPrefix</code> needs to be called before
<code>generateBlockId</code>; if the code were to be moved around later.
Another way that I think about it, is that <code>generateBlockId</code> uses
<code>this.blockIdPrefix</code>. The check ensures that the input it uses is
initialized before actually using it, independent of the code that actually
initializes the input.
Thanks
Siva
> Update WASB driver to use the latest version (4.2.0) of SDK for Microsoft
> Azure Storage Clients
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-13354
> URL: https://issues.apache.org/jira/browse/HADOOP-13354
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs/azure
> Reporter: Sivaguru Sankaridurg
> Attachments: HADOOP-13354.001.patch, HADOOP-13354.002.patch,
> HADOOP-13354.003.patch, HADOOP-13354.004.patch, Test-Results-With-4.2.0-fixes
>
>
> Update WASB driver to use the latest version (4.2.0) of SDK for Microsoft
> Azure Storage Clients.
> We are currently using version 2.2.0 of the SDK.
> Version 4.2.0 brings some breaking changes.
> Need to fix code to resolve all these breaking changes and certify that
> everything works properly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
