[ 
https://issues.apache.org/jira/browse/HADOOP-9565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397523#comment-15397523
 ] 

Pieter Reuse commented on HADOOP-9565:
--------------------------------------

Thanks for patch 006, Steve. Having Strings instead of bitmasks is definitely 
an improvement. But maybe an enum is worth considering here.

I don't think the Put command adds functionality. An ObjectStore-object is 
still a FileSystem-object, having the full FileSystem interface available. Or 
am I missing something here?

Thank you for mentioning ViewFs here, Chris. It's important that this patch 
doesn't break the great ease of use ViewFs brings. But considering ViewFs is 
client-side only and this patch only brings performance enhancements, I don't 
think it is worth the extra miles checking the config of ViewFs whether the 
Path belongs to an ObjectStore which is part of a ViewFs instance.

> Add a Blobstore interface to add to blobstore FileSystems
> ---------------------------------------------------------
>
>                 Key: HADOOP-9565
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9565
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs, fs/s3, fs/swift
>    Affects Versions: 2.6.0
>            Reporter: Steve Loughran
>            Assignee: Pieter Reuse
>         Attachments: HADOOP-9565-001.patch, HADOOP-9565-002.patch, 
> HADOOP-9565-003.patch, HADOOP-9565-004.patch, HADOOP-9565-005.patch, 
> HADOOP-9565-006.patch
>
>
> We can make the fact that some {{FileSystem}} implementations are really 
> blobstores, with different atomicity and consistency guarantees, by adding a 
> {{Blobstore}} interface to add to them. 
> This could also be a place to add a {{Copy(Path,Path)}} method, assuming that 
> all blobstores implement at server-side copy operation as a substitute for 
> rename.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to