[
https://issues.apache.org/jira/browse/HADOOP-13395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398387#comment-15398387
]
Andrew Wang commented on HADOOP-13395:
--------------------------------------
Looks good overall, thanks for working on this Xiao!
Few nitty comments:
* We introduce a new {{interval}} variable that's only used once, could we just
inline it? Seems a bit confusing too since we also have a {{sleepInterval}}
variable.
* Can we make the indentation the same for the new or case? This makes it
easier to diff visually.
In general, if we're trying to reduce flakiness, I'd like to do it by removing
the need for sleeps entirely. Is there some way to manually trigger aggregation
instead, perhaps via a VisibleForTesting method? This would also make the test
deterministic.
> Enhance TestKMSAudit
> --------------------
>
> Key: HADOOP-13395
> URL: https://issues.apache.org/jira/browse/HADOOP-13395
> Project: Hadoop Common
> Issue Type: Test
> Components: kms
> Affects Versions: 2.6.0
> Reporter: Xiao Chen
> Assignee: Xiao Chen
> Priority: Minor
> Attachments: HADOOP-13395.01.patch, HADOOP-13395.02.patch
>
>
> This jira serves the goals:
> - Enhance existing test cases in TestKMSAudit, to rule out flakiness.
> - Add a new test case about formatting for different events.
> This will help us ensure audit log compatibility when we add a new log format
> to KMS.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
