[ 
https://issues.apache.org/jira/browse/HADOOP-13434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398599#comment-15398599
 ] 

Larry McCay edited comment on HADOOP-13434 at 7/29/16 2:22 AM:
---------------------------------------------------------------

LGTM - removes bash where there are alternatives and quotes the rest.
+1 - pending jenkins green light.



was (Author: lmccay):
LGTM - removes bash where there are alternatives and quotes the rest.
+1


> Add quoting to Shell class
> --------------------------
>
>                 Key: HADOOP-13434
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13434
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>         Attachments: HADOOP-13434.patch, HADOOP-13434.patch
>
>
> The Shell class makes assumptions that the parameters won't have spaces or 
> other special characters, even when it invokes bash.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to