[ 
https://issues.apache.org/jira/browse/HADOOP-13395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiao Chen updated HADOOP-13395:
-------------------------------
    Attachment: HADOOP-13395.03.patch

Thanks a lot [~andrew.wang] for the review! Getting rid of {{sleep}} is 
definitely better. :)
Patch 3 is attached, addressing your comments. Please take a look and share 
your thoughts.

The major flakiness of the past occurrence is due to the race in different 
threads after an UNAUTHRIZED log - one UNAUTH log itself, and one aggregated OK 
log on the removal listener thread after UNAUTH. I put a comment in the test to 
explain it.



> Enhance TestKMSAudit
> --------------------
>
>                 Key: HADOOP-13395
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13395
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: kms
>    Affects Versions: 2.6.0
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>            Priority: Minor
>         Attachments: HADOOP-13395.01.patch, HADOOP-13395.02.patch, 
> HADOOP-13395.03.patch
>
>
> This jira serves the goals:
> - Enhance existing test cases in TestKMSAudit, to rule out flakiness.
> - Add a new test case about formatting for different events.
> This will help us ensure audit log compatibility when we add a new log format 
> to KMS.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to