[
https://issues.apache.org/jira/browse/HADOOP-13444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401439#comment-15401439
]
Akira Ajisaka commented on HADOOP-13444:
----------------------------------------
Thanks [~vincentpoon] for updating the patch! Mostly looks good to me.
Minor comment: Would you keep the order of import statements? For example, the
following statements
{code:title=KeyProvider.java}
import com.google.gson.stream.JsonWriter;
+ import java.nio.charset.StandardCharsets;
import org.apache.hadoop.classification.InterfaceAudience;
{code}
can be replaced as follows:
{code:title=KeyProvider.java}
import java.io.OutputStreamWriter;
+ import java.nio.charset.StandardCharsets;
import java.security.NoSuchAlgorithmException;
{code}
> Replace org.apache.commons.io.Charsets with java.nio.charset.StandardCharsets
> -----------------------------------------------------------------------------
>
> Key: HADOOP-13444
> URL: https://issues.apache.org/jira/browse/HADOOP-13444
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.7.2
> Reporter: Vincent Poon
> Priority: Minor
> Attachments: HADOOP-13444.2.patch, HADOOP-13444.3.patch,
> HADOOP-13444.patch
>
>
> org.apache.commons.io.Charsets is deprecated in favor of
> java.nio.charset.StandardCharsets
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
