[ 
https://issues.apache.org/jira/browse/HADOOP-13190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412982#comment-15412982
 ] 

Xiao Chen commented on HADOOP-13190:
------------------------------------

Thanks [~jojochuang] for revving! Looks pretty good, and I think we're close. 
Nice catch on the macro at the beginning BTW.

Nits:
- Seems a typo in KMS Client Configuration session. 'mustbe'.
- {{...(for example, a NameNode) }} -> {{(for example, HDFS NameNode) }}
- {{The host names}} -> {{hostnames}}
- {{For example, the following configuration in hdfs-site.xml sets up two KMS 
instances}}. Technically they don't 'set up' the 2, since they're client side. 
How about we s/sets up/configures/g ?
- Suggest we add 1 sentence to describe how LBKMSCP is used. Something like: 
When more than one key provider is configured in the uri, a LBKMSCP is 
automatically created. We can combine this with the intro about round-robin.

> LoadBalancingKMSClientProvider should be documented
> ---------------------------------------------------
>
>                 Key: HADOOP-13190
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13190
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: documentation, kms
>    Affects Versions: 2.7.0
>            Reporter: Wei-Chiu Chuang
>            Assignee: Wei-Chiu Chuang
>              Labels: supportability
>         Attachments: HADOOP-13190.001.patch, HADOOP-13190.002.patch
>
>
> Currently, there are two ways to achieve KMS HA.
> The first one, and the only documented one, is running multiple KMS instances 
> behind a load balancer. 
> https://hadoop.apache.org/docs/stable/hadoop-kms/index.html
> The other way, is make use of LoadBalancingKMSClientProvider which is added 
> in HADOOP-11620. However the usage is undocumented.
> I think we should update the KMS document to introduce 
> LoadBalancingKMSClientProvider, provide examples, and also update 
> kms-site.xml to explain it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to