[ 
https://issues.apache.org/jira/browse/HADOOP-13473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daryn Sharp updated HADOOP-13473:
---------------------------------
    Attachment: HADOOP-13473.patch

The htrace span is technically violating abstractions by accessing rpc headers 
in the ipc layer.  I tried to push the htrace scope down into the rpc 
engine/handler but that would alter the start time semantics from when it went 
in the queue, to when it was extracted.  Tried to create a span with the queue 
time, but htrace apis just aren't amiable to creating a scope from the manual 
span.

Anyway, just added a wrapper to lazy decode the rpc header.

> TestTracing#testTracing is failing in trunk 
> --------------------------------------------
>
>                 Key: HADOOP-13473
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13473
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.9.0, 3.0.0-alpha2
>            Reporter: Wei-Chiu Chuang
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-13473.patch
>
>
> Looks like the test has been failing since HADOOP-13438 was committed.
> https://builds.apache.org/job/PreCommit-HDFS-Build/16338/testReport/org.apache.hadoop.tracing/TestTracing/testTracing/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to