[ 
https://issues.apache.org/jira/browse/HADOOP-13494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Mackrory updated HADOOP-13494:
-----------------------------------
    Attachment: HADOOP-13494.003.patch

Thanks for the review.

Fixed Javadoc and a couple of other checkstyle issues. Also made the list 
configurable, simplified some of the defaults to improve readability without 
practically expanding what would get matched, and added 'password' to the list 
(to catch the ssl.*password properties you saw in DFSConfigKeys.java)

{quote}It makes the logic in ReconfigurableBase a little more complicated 
though, since we'll need per-Configuration redactors.{quote}

I'm not entirely sure I caught your meaning here. I had the list just get 
parsed from the property, with commas to separate expressions, and then used 
the list as before. Did you have something else in mind?

> ReconfigurableBase can log sensitive information
> ------------------------------------------------
>
>                 Key: HADOOP-13494
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13494
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 2.2.0
>            Reporter: Sean Mackrory
>            Assignee: Sean Mackrory
>         Attachments: HADOOP-13494.001.patch, HADOOP-13494.002.patch, 
> HADOOP-13494.003.patch
>
>
> ReconfigurableBase will log old and new configuration values, which may cause 
> sensitive parameters (most notably cloud storage keys, though there may be 
> other instances) to get included in the logs. 
> Given the currently small list of reconfigurable properties, an argument 
> could be made for simply not logging the property values at all, but this is 
> not the only instance where potentially sensitive configuration gets written 
> somewhere else in plaintext. I think a generic mechanism for redacting 
> sensitive information for textual display will be useful to some of the web 
> UIs too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to