[
https://issues.apache.org/jira/browse/HADOOP-13513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15426652#comment-15426652
]
Chris Nauroth commented on HADOOP-13513:
----------------------------------------
Hello [[email protected]]. Steve is referring to this policy in the Hadoop
contribution wiki:
https://wiki.apache.org/hadoop/HowToContribute#Submitting_patches_against_object_stores_such_as_Amazon_S3.2C_OpenStack_Swift_and_Microsoft_Azure
To summarize, for modules like hadoop-azure, hadoop-aws, etc., there are either
no unit tests running during Apache pre-commit, or there are unit tests in the
module, but we consider them insufficient to validate a patch for commit.
Instead, we require the contributor to run integration tests directly against
the back-end service. These are still structured as JUnit tests under the
src/test/java directory, but the tests get skipped unless the developer does
some extra configuration to make the necessary credentials available. The
exact configuration process varies per file system:
http://hadoop.apache.org/docs/r2.7.2/hadoop-aws/tools/hadoop-aws/index.html
http://hadoop.apache.org/docs/r2.7.2/hadoop-azure/index.html#Testing_the_hadoop-azure_Module
For this patch, I'm going to kick off my own test run for you now. We
currently have a test failure on branch-2 and branch-2.8 because of this, so I
want to get it fixed quickly. You can keep this information in mind for future
patches though.
> Java 1.7 support for org.apache.hadoop.fs.azure testcases
> ---------------------------------------------------------
>
> Key: HADOOP-13513
> URL: https://issues.apache.org/jira/browse/HADOOP-13513
> Project: Hadoop Common
> Issue Type: Bug
> Components: azure
> Affects Versions: 2.9.0
> Reporter: Tibor Kiss
> Assignee: Tibor Kiss
> Priority: Minor
> Fix For: 2.9.0
>
> Attachments: HADOOP-13513-001.patch
>
>
> Recent improvement on AzureNativeFileSystem rename/delete performance
> (HADOOP-13403) yielded a test change (HADOOP-13459) which is incompatible
> with Java 1.7.
> If one tries to include those patches in a Java 1.7 compatible Hadoop tree
> (e.g. 2.7.x) the following error occurs during test run:
> {code}
> initializationError(org.apache.hadoop.fs.azure.TestNativeAzureFileSystemClientLogging)
> Time elapsed: 0.001 sec <<< ERROR!
> java.lang.Exception: Class org.apache.hadoop.fs.azure.AbstractWasbTestBase
> should be public
> at
> org.junit.runners.model.FrameworkMethod.validatePublicVoid(FrameworkMethod.java:91)
> at
> org.junit.runners.model.FrameworkMethod.validatePublicVoidNoArg(FrameworkMethod.java:70)
> at
> org.junit.runners.ParentRunner.validatePublicVoidNoArgMethods(ParentRunner.java:133)
> at
> org.junit.runners.BlockJUnit4ClassRunner.validateInstanceMethods(BlockJUnit4ClassRunner.java:165)
> at
> org.junit.runners.BlockJUnit4ClassRunner.collectInitializationErrors(BlockJUnit4ClassRunner.java:104)
> at org.junit.runners.ParentRunner.validate(ParentRunner.java:355)
> at org.junit.runners.ParentRunner.<init>(ParentRunner.java:76)
> at
> org.junit.runners.BlockJUnit4ClassRunner.<init>(BlockJUnit4ClassRunner.java:57)
> at
> org.junit.internal.builders.JUnit4Builder.runnerForClass(JUnit4Builder.java:10)
> at
> org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:59)
> at
> org.junit.internal.builders.AllDefaultPossibilitiesBuilder.runnerForClass(AllDefaultPossibilitiesBuilder.java:26)
> at
> org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:59)
> at
> org.junit.internal.requests.ClassRequest.getRunner(ClassRequest.java:26)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:262)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124)
> at
> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
> {code}
> The problem can be resolved by setting {{AbstractWasbTestBase}} to {{public}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
