[
https://issues.apache.org/jira/browse/HADOOP-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15426677#comment-15426677
]
Wei-Chiu Chuang commented on HADOOP-13396:
------------------------------------------
Hi [~xiaochen] thanks again for the new patch.
1.
{code}
auditLog.info(new String(output.toByteArray(), "UTF-8"));
{code}
can be changed to
{code}
auditLog.info(output.toString("UTF-8"));
{code}
2. {{KMSAudit#initializeAuditLoggers}} I think it's fine to keep it as is. But
if we ever want to add new type of audit loggers, I would suggest to change
this to a factory method. I don't feel strongly about this, so this is just a
note.
Other than this, I think this patch is ready.
> Add json format audit logging to KMS
> ------------------------------------
>
> Key: HADOOP-13396
> URL: https://issues.apache.org/jira/browse/HADOOP-13396
> Project: Hadoop Common
> Issue Type: New Feature
> Components: kms
> Reporter: Xiao Chen
> Assignee: Xiao Chen
> Attachments: HADOOP-13396.01.patch, HADOOP-13396.02.patch,
> HADOOP-13396.03.patch, HADOOP-13396.04.patch, HADOOP-13396.05.patch,
> HADOOP-13396.06.patch
>
>
> Currently, KMS audit log is using log4j, to write a text format log.
> We should refactor this, so that people can easily add new format audit logs.
> The current text format log should be the default, and all of its behavior
> should remain compatible.
> A json format log extension is added using the refactored API, and being
> turned off by default.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
