[ 
https://issues.apache.org/jira/browse/HADOOP-13447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429438#comment-15429438
 ] 

Chris Nauroth commented on HADOOP-13447:
----------------------------------------

Checkstyle flagged "3 new" warnings.  I do not intend to fix these.  One is a 
long parameter list that isn't really a new warning, but it got flagged because 
I changed the type of one of the parameters.  The others are complaints about 
exposing protected member variables without wrapper accessor methods in my new 
abstract base class for mock-based tests.  Adding accessor methods would just 
make subclass code more cumbersome, and since this is private test code, there 
is no risk of poor encapsulation for any public interface.

> Refactor S3AFileSystem to support introduction of separate metadata 
> repository and tests.
> -----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-13447
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13447
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-13447-HADOOP-13446.001.patch, 
> HADOOP-13447-HADOOP-13446.002.patch, HADOOP-13447.003.patch, 
> HADOOP-13447.004.patch
>
>
> The scope of this issue is to refactor the existing {{S3AFileSystem}} into 
> multiple coordinating classes.  The goal of this refactoring is to separate 
> the {{FileSystem}} API binding from the AWS SDK integration, make code 
> maintenance easier while we're making changes for S3Guard, and make it easier 
> to mock some implementation details so that tests can simulate eventual 
> consistency behavior in a deterministic way.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to