[ 
https://issues.apache.org/jira/browse/HADOOP-13446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431379#comment-15431379
 ] 

Aaron Fabbri commented on HADOOP-13446:
---------------------------------------

Reviewing trunk 006 patch. Comparing to 002 version I reviewed previously, 
similar to branch-2 patch:

- ITestS3AContractGetFileStatus: force multiple responses by lowering 
fs.s3a.paging.maximum to 2 (same as in latest branch-2 patch)
- Style fixes, comment improvements.
- Add credential provider test cases for unit and integration tests (invalid 
class)
- Move some deletion tests to be Integration tests
- Enhancements for ITestS3ADirectoryPerf

+1 on this patch as well (I'm only committer on branch though)

Shout if you want me to run these tests as well.



> Support running isolated unit tests separate from AWS integration tests.
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-13446
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13446
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-13446-HADOOP-13345.001.patch, 
> HADOOP-13446-HADOOP-13345.002.patch, HADOOP-13446-HADOOP-13345.003.patch, 
> HADOOP-13446-branch-2.006.patch, HADOOP-13446.004.patch, 
> HADOOP-13446.005.patch, HADOOP-13446.006.patch
>
>
> Currently, the hadoop-aws module only runs Surefire if AWS credentials have 
> been configured.  This implies that all tests must run integrated with the 
> AWS back-end.  It also means that no tests run as part of ASF pre-commit.  
> This issue proposes for the hadoop-aws module to support running isolated 
> unit tests without integrating with AWS.  This will benefit S3Guard, because 
> we expect the need for isolated mock-based testing to simulate eventual 
> consistency behavior.  It also benefits hadoop-aws in general by allowing 
> pre-commit to do something more valuable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to