[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15433626#comment-15433626
]
Aaron Fabbri commented on HADOOP-13448:
---------------------------------------
Thanks for the patch! Looks pretty good, especially since we will evolve it as
needed.
- I really like having initialize() / Closable as well.
- put() / putNew() this is fine to eliminate putNew().. I wasn't convinced the
distinction was necessary. We'll need to go through the same exercise of
defining precise semantics, and writing test cases, that we've done for the FS
Contract test stuff. We can always add putNew() if the distinction is useful.
On PathMetadata:
- Could also use a private boolean isDirectory instead introducing separate
private class to return true/false. Besides saving a couple of lines of code,
it may make the next suggestion clearer in the code... (Not a biggie though)
On listChildren() return type:
- I think we need more than a List<PathMetadata> if we are to express
fully-cached directories, so callers--e.g. listStatus()--know if they may avoid
a round trip to blobstore. How about an additional type, say,
DirectoryListMetadata (I'd called it CachedDirectory). It is essentially a
struct of List<PathMetadata> + extra state. The extra state I want, so far, is
just the "fully cached" boolean flag.
Please shout if any of that is not clear... I'm a little sleep-deprived today.
> S3Guard: Define MetadataStore interface.
> ----------------------------------------
>
> Key: HADOOP-13448
> URL: https://issues.apache.org/jira/browse/HADOOP-13448
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Attachments: HADOOP-13448-HADOOP-13345.001.patch
>
>
> Define the common interface for metadata store operations. This is the
> interface that any metadata back-end must implement in order to integrate
> with S3Guard.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
