[ 
https://issues.apache.org/jira/browse/HADOOP-13539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437303#comment-15437303
 ] 

Xiao Chen commented on HADOOP-13539:
------------------------------------

I see, that makes sense.

But in that case do we want to throw a RTE? I think an IOE would trigger the 
client 
[retry|https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/LoadBalancingKMSClientProvider.java#L97]

> KMS's zookeeper-based secret manager should be consistent when failed to 
> remove node
> ------------------------------------------------------------------------------------
>
>                 Key: HADOOP-13539
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13539
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: kms
>    Affects Versions: 2.6.0
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>         Attachments: HADOOP-13539.01.patch
>
>
> In {{ZKDelegationTokenSecretManager}}, the 2 methods 
> {{removeStoredMasterKey}} and {{removeStoredToken}} are very much alike, yet 
> handles exception differently. We should not throw RTE if a node cannot be 
> removed - logging is enough.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to