[
https://issues.apache.org/jira/browse/HADOOP-13375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15454814#comment-15454814
]
Weiwei Yang commented on HADOOP-13375:
--------------------------------------
Hello [~liuml07]
Sorry I missed your 1st comment :( earlier. Regarding to your concern, it
doesn't bother me too much because
* The only method used in multiple threads is {{latch.await()}}, this doesn't
change latch's state.
* {{FakeGroupMapping.resume()}} changes the state but it is only called in main
thread.
So I don't think there will be any thread safety issues. I agree to add
{{volatile}} that makes sense, so I added it in v7 patch so I am good for
either ways. Appreciate your thoroughly review!
> o.a.h.security.TestGroupsCaching.testBackgroundRefreshCounters seems flaky
> --------------------------------------------------------------------------
>
> Key: HADOOP-13375
> URL: https://issues.apache.org/jira/browse/HADOOP-13375
> Project: Hadoop Common
> Issue Type: Bug
> Components: security, test
> Affects Versions: 2.8.0
> Reporter: Mingliang Liu
> Assignee: Weiwei Yang
> Attachments: HADOOP-13375.001.patch, HADOOP-13375.002.patch,
> HADOOP-13375.003.patch, HADOOP-13375.004.patch, HADOOP-13375.005.patch,
> HADOOP-13375.006.patch, HADOOP-13375.007.patch
>
>
> h5. Error Message
> bq. expected:<1> but was:<0>
> h5. Stacktrace
> {quote}
> java.lang.AssertionError: expected:<1> but was:<0>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:555)
> at org.junit.Assert.assertEquals(Assert.java:542)
> at
> org.apache.hadoop.security.TestGroupsCaching.testBackgroundRefreshCounters(TestGroupsCaching.java:638)
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
