[
https://issues.apache.org/jira/browse/HADOOP-13341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15474086#comment-15474086
]
ASF GitHub Bot commented on HADOOP-13341:
-----------------------------------------
GitHub user aw-was-here opened a pull request:
https://github.com/apache/hadoop/pull/126
HADOOP-13341: Deprecate HADOOP_SERVERNAME_OPTS; replace with
(command)_(subcommand)_OPTS
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/hadoop HADOOP-13341
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/hadoop/pull/126.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #126
----
commit f462c9d73467eec3be19830829005f1136577e0b
Author: Allen Wittenauer <[email protected]>
Date: 2016-07-08T16:25:09Z
HADOOP-13356. Add a function to handle command_subcommand_OPTS (aw)
Signed-off-by: Allen Wittenauer <[email protected]>
commit 0e011b79143e3fc2d9063b466bd17ecdfe7a9ac6
Author: Allen Wittenauer <[email protected]>
Date: 2016-08-26T21:33:33Z
HADOOP-13355. Handle HADOOP_CLIENT_OPTS in a function (aw)
Signed-off-by: Allen Wittenauer <[email protected]>
commit ff98786144ebc1d21127a13850bb943a76ceac01
Author: Allen Wittenauer <[email protected]>
Date: 2016-08-28T17:45:00Z
HADOOP-13358. Modify HDFS to use hadoop_subcommand_opts
Signed-off-by: Allen Wittenauer <[email protected]>
commit 6bc45fa90f509cae020eb70a4d540ae215893dc6
Author: Allen Wittenauer <[email protected]>
Date: 2016-08-30T15:16:23Z
HADOOP-13554. Add an equivalent of hadoop_subcmd_opts for secure opts (aw)
commit d03c6f835dad5963e90d45e047077a7c270c1d5e
Author: Allen Wittenauer <[email protected]>
Date: 2016-08-30T15:52:41Z
HADOOP-13562. Change hadoop_subcommand_opts to use only uppercase
commit 1a3e102cdf5be3b88c9101bfafe0189b9ed98165
Author: Allen Wittenauer <[email protected]>
Date: 2016-08-30T19:42:32Z
HADOOP-13357. Modify common to use hadoop_subcommand_opts
commit 7f75b084ebb1630be935642f69033c91a242b171
Author: Allen Wittenauer <[email protected]>
Date: 2016-08-30T20:03:45Z
HADOOP-13359. Modify YARN to use hadoop_subcommand_opts
commit 59b59ca8564a09c06e4c0b2aed73ef1e94c087dc
Author: Allen Wittenauer <[email protected]>
Date: 2016-08-30T20:55:04Z
HADOOP-13361. Modify hadoop_verify_user to be consistent with
hadoop_subcommand_opts (ie more granularity)
Signed-off-by: Allen Wittenauer <[email protected]>
commit 930e03b71e779772bb75e15ed5503c7392a68fdd
Author: Allen Wittenauer <[email protected]>
Date: 2016-08-30T22:11:24Z
HADOOP-13564. modify mapred to use hadoop_subcommand_opts
Signed-off-by: Allen Wittenauer <[email protected]>
commit dc6d4900d270a714d05055b822983cd3198aba61
Author: Allen Wittenauer <[email protected]>
Date: 2016-08-30T22:23:29Z
HADOOP-13563. hadoop_subcommand_opts should print name not actual content
during debug
Signed-off-by: Allen Wittenauer <[email protected]>
commit 5b7a3df75c6fc78793bf8638f3ddaa11f7e0658e
Author: Allen Wittenauer <[email protected]>
Date: 2016-08-31T14:39:34Z
HADOOP-13360. Documentation for HADOOP_subcommand_OPTS
Signed-off-by: Allen Wittenauer <[email protected]>
----
> Deprecate HADOOP_SERVERNAME_OPTS; replace with (command)_(subcommand)_OPTS
> --------------------------------------------------------------------------
>
> Key: HADOOP-13341
> URL: https://issues.apache.org/jira/browse/HADOOP-13341
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Affects Versions: 3.0.0-alpha1
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Attachments: HADOOP-13341.00.patch
>
>
> Big features like YARN-2928 demonstrate that even senior level Hadoop
> developers forget that daemons need a custom _OPTS env var. We can replace
> all of the custom vars with generic handling just like we do for the username
> check.
> For example, with generic handling in place:
> || Old Var || New Var ||
> | HADOOP_NAMENODE_OPTS | HDFS_NAMENODE_OPTS |
> | YARN_RESOURCEMANAGER_OPTS | YARN_RESOURCEMANAGER_OPTS |
> | n/a | YARN_TIMELINEREADER_OPTS |
> | n/a | HADOOP_DISTCP_OPTS |
> | n/a | MAPRED_DISTCP_OPTS |
> | HADOOP_DN_SECURE_EXTRA_OPTS | HDFS_DATANODE_SECURE_EXTRA_OPTS |
> | HADOOP_NFS3_SECURE_EXTRA_OPTS | HDFS_NFS3_SECURE_EXTRA_OPTS |
> | HADOOP_JOB_HISTORYSERVER_OPTS | MAPRED_HISTORYSERVER_OPTS |
> This makes it:
> a) consistent across the entire project
> b) consistent for every subcommand
> c) eliminates almost all of the custom appending in the case statements
> It's worth pointing out that subcommands like distcp that sometimes need a
> higher than normal client-side heapsize or custom options are a huge win.
> Combined with .hadooprc and/or dynamic subcommands, it means users can easily
> do customizations based upon their needs without a lot of weirdo shell
> aliasing or one line shell scripts off to the side.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
