[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15475367#comment-15475367
]
Chris Nauroth edited comment on HADOOP-13448 at 9/8/16 11:43 PM:
-----------------------------------------------------------------
I have attached patch 004.
bq. Should this be "return
Collections.unmodifiableCollection(listMap.values())" )?
Yes, good idea. I made this change and added a test for it.
bq. I think this function will change to expose the same PathMetadata return
value. Thoughts?
Yes, that makes sense. Would both {{get}} and {{put}} change to work with
{{PathMetadata}} instead of a raw {{FileStatus}}? I think so. I can update
the patch one more time if you agree.
bq. So, if the path exists but dir is empty, we get a DirListingMetadata with
an empty list of children.
I incorporated your JavaDoc change. I agree that returning {{null}} is
preferrable over throwing {{FileNotFoundException}}.
was (Author: cnauroth):
bq. Should this be "return
Collections.unmodifiableCollection(listMap.values())" )?
Yes, good idea. I made this change and added a test for it.
bq. I think this function will change to expose the same PathMetadata return
value. Thoughts?
Yes, that makes sense. Would both {{get}} and {{put}} change to work with
{{PathMetadata}} instead of a raw {{FileStatus}}? I think so. I can update
the patch one more time if you agree.
bq. So, if the path exists but dir is empty, we get a DirListingMetadata with
an empty list of children.
I incorporated your JavaDoc change. I agree that returning {{null}} is
preferrable over throwing {{FileNotFoundException}}.
> S3Guard: Define MetadataStore interface.
> ----------------------------------------
>
> Key: HADOOP-13448
> URL: https://issues.apache.org/jira/browse/HADOOP-13448
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Attachments: HADOOP-13448-HADOOP-13345.001.patch,
> HADOOP-13448-HADOOP-13345.002.patch, HADOOP-13448-HADOOP-13345.003.patch,
> HADOOP-13448-HADOOP-13345.004.patch
>
>
> Define the common interface for metadata store operations. This is the
> interface that any metadata back-end must implement in order to integrate
> with S3Guard.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
