[ 
https://issues.apache.org/jira/browse/HADOOP-13589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478315#comment-15478315
 ] 

Chris Nauroth commented on HADOOP-13589:
----------------------------------------

My initial implementation idea is to add another Maven profile that activates 
S3Guard in integration tests.  The profile would configure 
maven-resources-plugin to deploy a customized core-site.xml onto the test 
classpath.  The customized core-site.xml would flip the switch to enable 
S3Guard.

We could also use resource filtering to allow additional command line arguments 
for further customizations, such as switching between different metadata store 
implementation classes.  It's possible that XInclude from the existing 
src/test/resources/core-site.xml would simplify this.

In some cases, we may see intentional differences in behavior with S3Guard 
enabled.  In those cases, test code might need to be changed.  For example, if 
S3Guard can provide file visiblity on create semantics (not currently provided 
by S3A), then when S3Guard is enabled, we have an opportunity to run 
{{AbstractContractCreateTest#testCreatedFileIsImmediatelyVisible}} (currently 
skipped) and have it succeed.

> S3Guard: Allow execution of all S3A integration tests with S3Guard enabled.
> ---------------------------------------------------------------------------
>
>                 Key: HADOOP-13589
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13589
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Chris Nauroth
>
> With S3Guard enabled, S3A must continue to be functionally correct.  The best 
> way to verify this is to execute our existing S3A integration tests in a mode 
> with S3A enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to