[
https://issues.apache.org/jira/browse/HADOOP-13583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478847#comment-15478847
]
Robert Kanter commented on HADOOP-13583:
----------------------------------------
Another thing: If it finds any incompatibilities, it returns an exit code of
1, so the call to {{subprocess.check_call(args)}} in {{run_java_acc}} fails and
you don't get any useful output in the terminal, though it still generates the
html report:
{noformat}
Traceback (most recent call last):
File "./dev-support/bin/checkcompatibility.py", line 337, in <module>
main()
File "./dev-support/bin/checkcompatibility.py", line 333, in main
dst_rev, dst_jars, annotations)
File "./dev-support/bin/checkcompatibility.py", line 196, in run_java_acc
subprocess.check_output(args)
File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
line 573, in check_output
raise CalledProcessError(retcode, cmd, output=output)
subprocess.CalledProcessError: Command '['perl',
'/Users/rkanter/dev/hadoop-common2/dev-support/target/java-acc/japi-compliance-checker-1.8/japi-compliance-checker.pl',
'-l', 'hadoop', '-d1',
'/Users/rkanter/dev/hadoop-common2/target/compat-check/src.xml', '-d2',
'/Users/rkanter/dev/hadoop-common2/target/compat-check/dst.xml',
'-report-path',
'/Users/rkanter/dev/hadoop-common2/target/compat-check/report.html',
'-annotations-list',
'/Users/rkanter/dev/hadoop-common2/target/compat-check/annotations.txt']'
returned non-zero exit status 1
{noformat}
The error codes are listed at
http://lvc.github.io/japi-compliance-checker/#Error
It sounds like we should have the python code allow an exit code of either 0 or
1.
> Incorporate checkcompatibility script which runs Java API Compliance Checker
> ----------------------------------------------------------------------------
>
> Key: HADOOP-13583
> URL: https://issues.apache.org/jira/browse/HADOOP-13583
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Affects Versions: 2.6.4
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: HADOOP-13583.001.patch
>
>
> Based on discussion at YETUS-445, this code can't go there, but it's still
> very useful for release managers. A similar variant of this script has been
> used for a while by Apache HBase and Apache Kudu, and IMO JACC output is
> easier to understand than JDiff.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
