[ 
https://issues.apache.org/jira/browse/HADOOP-13341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15484919#comment-15484919
 ] 

Hudson commented on HADOOP-13341:
---------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10426 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/10426/])
HADOOP-13341.  Deprecate HADOOP_SERVERNAME_OPTS; replace with (aw: rev 
58ed4fa5449872d65efd52d840f02dd60af2771a)
* (edit) hadoop-yarn-project/hadoop-yarn/bin/yarn
* (add) 
hadoop-common-project/hadoop-common/src/test/scripts/hadoop_add_client_opts.bats
* (edit) 
hadoop-tools/hadoop-streaming/src/main/shellprofile.d/hadoop-streaming.sh
* (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs-config.sh
* (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsNfsGateway.md
* (add) 
hadoop-common-project/hadoop-common/src/test/scripts/hadoop_subcommand_opts.bats
* (edit) hadoop-common-project/hadoop-common/src/site/markdown/ClusterSetup.md
* (edit) hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
* (edit) hadoop-mapreduce-project/conf/mapred-env.sh
* (edit) hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
* (add) 
hadoop-common-project/hadoop-common/src/test/scripts/hadoop_subcommand_secure_opts.bats
* (add) 
hadoop-common-project/hadoop-common/src/test/scripts/hadoop_verify_user.bats
* (edit) hadoop-tools/hadoop-sls/src/main/bin/slsrun.sh
* (edit) 
hadoop-tools/hadoop-archive-logs/src/main/shellprofile.d/hadoop-archive-logs.sh
* (edit) hadoop-tools/hadoop-rumen/src/main/shellprofile.d/hadoop-rumen.sh
* (edit) hadoop-common-project/hadoop-common/src/site/markdown/UnixShellGuide.md
* (edit) hadoop-common-project/hadoop-common/src/main/bin/hadoop
* (edit) hadoop-tools/hadoop-distcp/src/main/shellprofile.d/hadoop-distcp.sh
* (edit) hadoop-tools/hadoop-extras/src/main/shellprofile.d/hadoop-extras.sh
* (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
* (edit) hadoop-mapreduce-project/bin/mapred
* (edit) hadoop-mapreduce-project/bin/mapred-config.sh
* (edit) hadoop-tools/hadoop-sls/src/main/bin/rumen2sls.sh


> Deprecate HADOOP_SERVERNAME_OPTS; replace with (command)_(subcommand)_OPTS
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-13341
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13341
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>             Fix For: 3.0.0-alpha2
>
>         Attachments: HADOOP-13341.00.patch
>
>
> Big features like YARN-2928 demonstrate that even senior level Hadoop 
> developers forget that daemons need a custom _OPTS env var.  We can replace 
> all of the custom vars with generic handling just like we do for the username 
> check.
> For example, with generic handling in place:
> || Old Var || New Var ||
> | HADOOP_NAMENODE_OPTS | HDFS_NAMENODE_OPTS |
> | YARN_RESOURCEMANAGER_OPTS | YARN_RESOURCEMANAGER_OPTS |
> | n/a | YARN_TIMELINEREADER_OPTS |
> | n/a | HADOOP_DISTCP_OPTS |
> | n/a | MAPRED_DISTCP_OPTS |
> | HADOOP_DN_SECURE_EXTRA_OPTS | HDFS_DATANODE_SECURE_EXTRA_OPTS |
> | HADOOP_NFS3_SECURE_EXTRA_OPTS | HDFS_NFS3_SECURE_EXTRA_OPTS |
> | HADOOP_JOB_HISTORYSERVER_OPTS | MAPRED_HISTORYSERVER_OPTS |
> This makes it:
> a) consistent across the entire project
> b) consistent for every subcommand
> c) eliminates almost all of the custom appending in the case statements
> It's worth pointing out that subcommands like distcp that sometimes need a 
> higher than normal client-side heapsize or custom options are a huge win.  
> Combined with .hadooprc and/or dynamic subcommands, it means users can easily 
> do customizations based upon their needs without a lot of weirdo shell 
> aliasing or one line shell scripts off to the side.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to