[
https://issues.apache.org/jira/browse/HADOOP-13594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15487524#comment-15487524
]
Sean Busbey edited comment on HADOOP-13594 at 9/13/16 3:29 PM:
---------------------------------------------------------------
the effect would be maven failing the build.
what does this buy us over the current flagging from precommit checks for
findbugs errors? are the error messages sufficient to guide a new contributor
in fixing things themselves, or is this likely to result in new folks
complaining about the build breaking in confusing ways when their "simple" fix
includes a findbugs error?
was (Author: busbey):
the effect would be maven failing the build.
what does this buy use over the current flagging from precommit checks for
findbugs errors? are the error messages sufficient to guide a new contributor
in fixing things themselves, or is this likely to result in new folks
complaining about the build breaking in confusing ways when their "simple" fix
includes a findbugs error?
> findbugs warnings to block a build
> ----------------------------------
>
> Key: HADOOP-13594
> URL: https://issues.apache.org/jira/browse/HADOOP-13594
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Tsuyoshi Ozawa
> Attachments: HADOOP-13594.001.patch
>
>
> findbugs is good tool, but we need to run separate command(mvn
> findbugs:check).
> Instead, it's better to run findbugs at compile time and block builds if it
> find errors.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
