[
https://issues.apache.org/jira/browse/HADOOP-13573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494564#comment-15494564
]
Chris Nauroth commented on HADOOP-13573:
----------------------------------------
Thank you for the updated patch. I think we just have one more assertion that
flipped the expected and actual arguments:
{code}
assertEquals("Cached file size correct.", meta.getFileStatus().getLen(),
200);
{code}
Can you please change that?
Also, are you planning to address the TODOs now, or in a later JIRA? I'm fine
either way. Since this is a feature branch, we have freedom to leave temporary
TODOs.
> S3Guard: create basic contract tests for MetadataStore implementations
> ----------------------------------------------------------------------
>
> Key: HADOOP-13573
> URL: https://issues.apache.org/jira/browse/HADOOP-13573
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Reporter: Aaron Fabbri
> Assignee: Aaron Fabbri
> Attachments: HADOOP-13573-HADOOP-13345.002.patch,
> HADOOP-13573.001.patch
>
>
> We should have some contract-style unit tests for the MetadataStore interface
> to validate that the different implementations provide correct semantics.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
