[ 
https://issues.apache.org/jira/browse/HADOOP-13591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502391#comment-15502391
 ] 

Kai Zheng commented on HADOOP-13591:
------------------------------------

Thanks Genmao for the update. It looks very close now. Some minors:

* Please use {{StringUtils.isEmpty}} instead as mentioned above.
{code}
+    String key = pathToKey(f);
+    if (!key.isEmpty() && !exists(f)) {
+      LOG.debug("Creating new fake directory at {}", f);

...

+    if (null != keysToDelete && !keysToDelete.isEmpty()) {
+      DeleteObjectsRequest deleteRequest =
+          new DeleteObjectsRequest(bucketName);

...

+    if (!key.isEmpty()) {
+      if (!key.endsWith("/")) {
+        dirName += "/";
+      }
{code}

Looks like the find-bugs issue already got fixed? Please help also check. 
Thanks.

> Unit test failure in TestOSSContractGetFileStatus and TestOSSContractRootDir 
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-13591
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13591
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs
>    Affects Versions: HADOOP-12756
>            Reporter: Genmao Yu
>            Assignee: Genmao Yu
>             Fix For: HADOOP-12756
>
>         Attachments: HADOOP-13591-HADOOP-12756.001.patch, 
> HADOOP-13591-HADOOP-12756.002.patch, HADOOP-13591-HADOOP-12756.003.patch, 
> HADOOP-13591-HADOOP-12756.004.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to