Steve Loughran commented on HADOOP-12834:

Looking at the code again, I think FileNotFoundExceptions could be rethrown 
directory as FNFEs, rather than caught and wrapped. Filesystems all include the 
filename here, and the exception class is more meaningfull. 

Class generally looks ready for migration to try-with-resources, SLF4J, ...

> Credentials to include text of inner IOE when rethrowing wrapped
> ----------------------------------------------------------------
>                 Key: HADOOP-12834
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12834
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: 2.8.0
>            Reporter: Steve Loughran
>            Priority: Minor
> Currently Credentials read/write methods catch IOEs and rethrow with the 
> filename (good), only they don't include the text of the caught exception in 
> the new string message (bad) ... you need to delve into the stack traces to 
> find the cause.
> fix: include the {{toString()}} value of the caught IOE in the new exception

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to