Mingliang Liu commented on HADOOP-13452:

I do that. This code looks the same as mine, except I do not override load 
factor to 1.0 (which saves space at expense of runtime).
The point I was making is about the access order of the LinkedHashMap. 
{{super(initialCapacity);}} by default, is using the insert order. 
{{super(maxEntries + 1, 1.0f, true);}} along with the overridden 
{{removeEldestEntry()}} will just make a LruCache. Sorry I should not have 
mentioned {{removeEldestEntry()}} as your patch is pretty good regarding that. 
If your motivation is about flexibility, I think it makes sense. Thanks.

> S3Guard: Implement access policy for intra-client consistency with in-memory 
> metadata store.
> --------------------------------------------------------------------------------------------
>                 Key: HADOOP-13452
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13452
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Chris Nauroth
>            Assignee: Aaron Fabbri
>         Attachments: HADOOP-13452.001.patch
> Implement an S3A access policy based on an in-memory metadata store.  This 
> can provide consistency within the same client without needing to integrate 
> with an external system.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to