Xiao Chen commented on HADOOP-13317:

Thanks for working on this, [~surajacharya]! I'm very happy to see this 
improved. :)

A few comments:
- Please make sure the trace is logged at the entry of each call - I guess 
that's their intended use, we have debug logs soon after. (e.g. move it to 
before the {{Meter#mark()}} in {{createKey}}
- I believe slf4j doesn't need to have the wrapper {{isTraceEnabled}} or 
{{isDebugEnabled}} if we provide a format string, because there is [no extra 
cost when they're 
- Same as above, let's use placeholders '{}' for the logs.
- We can possibly combine some of the debug logs. For example, {{createKey}} we 
can print sth like {{LOG.debug("length is {}, description is {}", length, 
description)}} to reduce message number. Also for {{createKey}}, is it safe to 
put cipher in the logs?
- I also remember seeing when the underlying provider throws an exception, it 
just propagates into tomcat and we ends up seeing nothing in the KMS log. Can 
we also take care of that?

> Add logs to KMS servier-side to improve supportability
> ------------------------------------------------------
>                 Key: HADOOP-13317
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13317
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: kms
>            Reporter: Xiao Chen
>            Assignee: Suraj Acharya
>            Priority: Minor
>              Labels: supportability
>         Attachments: HADOOP-13317-1.patch, HADOOP-13317.patch
> [KMS.java|https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java]
>  is the main class that serves KMS http requests. There're currently no logs 
> at all, making trouble shooting difficult.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to