[
https://issues.apache.org/jira/browse/HADOOP-13627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15515869#comment-15515869
]
Steve Loughran commented on HADOOP-13627:
-----------------------------------------
this is coming together nicely
# you can do a static import of {{ import static
org.apache.hadoop.security.UGIExceptionMessages.*}} to pull in all the texts;
# can you leave the signatures of the methods alone? You can add in the
javadocs a @throws KerberosAuthException
just to make clear what happens
# can you add some getters to the structured values? That way things like KDiag
can do more with it
> Have an explicit KerberosAuthException for UGI to throw, text from public
> constants
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-13627
> URL: https://issues.apache.org/jira/browse/HADOOP-13627
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
> Affects Versions: 2.7.3
> Reporter: Steve Loughran
> Assignee: Xiao Chen
> Attachments: HADOOP-13627.01.patch, HADOOP-13627.02.patch
>
>
> UGI creates simple IOEs on failure, making it impossible to catch them,
> ignore them, have smart retry logic around them, etc.
> # Have an explicit exception like {{KerberosAuthException extends
> IOException}} to raise instead. We can't use {{AuthenticationException}} as
> that doesn't extend IOE.
> # move {{UGI}}, {{SecurityUtil}} and things related off simple IOEs and into
> the new one
> # review exceptions raised and consider if they can provide more information
> # for the strings that get created, put them as public static constants, so
> that tests can look for them explicitly —tests that don't break if the text
> is changed.
> # maybe, {{getUGIFromTicketCache}} to throw this rather than an RTE if no
> login principals were found (it throws IOEs on login failures, after all)
> # keep KDiag in sync with this
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
