[ 
https://issues.apache.org/jira/browse/HADOOP-13644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15517537#comment-15517537
 ] 

Mingliang Liu commented on HADOOP-13644:
----------------------------------------

Thanks for the patch.

For easy review and Jenkins process, we can fix them by modules, e.g. hadoop 
common, hadoop hdfs, hadoop tools, hadoop yarn etc. For each module, we can 
replace those key literal strings in one patch. This JIRA can be an umbrella 
one.

> Replace config key literal strings with config key names 
> ---------------------------------------------------------
>
>                 Key: HADOOP-13644
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13644
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>            Reporter: Mingliang Liu
>            Assignee: Chen Liang
>            Priority: Minor
>         Attachments: HADOOP-13644.001.patch
>
>
> There are some places that use config key literal strings instead of config 
> key names, e.g.
> {code:title=IOUtils.java}
>     copyBytes(in, out, conf.getInt("io.file.buffer.size", 4096), true);
> {code}
> We should replace places like this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to