[ 
https://issues.apache.org/jira/browse/HADOOP-12974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15517567#comment-15517567
 ] 

Wei-Chiu Chuang commented on HADOOP-12974:
------------------------------------------

Thanks [~eclark] for the patch. I reviewed it and I think it's almost ready. 
Here's my comment just for reference:

* So DFCachingGetSpaceUsed doesn't really use unix df to get disk usage. 
Instead, it uses Java's File class API.
* Also, the interval parameter is not used.
* The DF object in DFCachingGetSpaceUsed can be made {{final}}.

> Create a CachingGetSpaceUsed implementation that uses df
> --------------------------------------------------------
>
>                 Key: HADOOP-12974
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12974
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: 2.9.0
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>         Attachments: HADOOP-12974v0.patch, HADOOP-12974v1.patch, 
> HADOOP-12974v2.patch, HADOOP-12974v3.patch, HADOOP-12974v4.patch, 
> HADOOP-12974v5.patch, HADOOP-12974v6.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to