[
https://issues.apache.org/jira/browse/HADOOP-13317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15523645#comment-15523645
]
Xiao Chen commented on HADOOP-13317:
------------------------------------
Thanks for the new rev, Suraj! Overall looks great. +1 pending the following:
In {{generateEncryptedKeys}}:
{code}
LOG.error("Exception in generateEncryptedKeys, Exception type {}," +
"Exception Message {}", e, e.toString());
{code}
Prefer to add a debug log with full stacktrace here.
{code}
LOG.error("IllegalArgumentException Wrong {} value, it must be {} or {}",
KMSRESTConstants.EEK_OP, KMSRESTConstants.EEK_GENERATE,
KMSRESTConstants.EEK_DECRYPT);
throw new IllegalArgumentException("Wrong " + KMSRESTConstants.EEK_OP +
" value, it must be " + KMSRESTConstants.EEK_GENERATE + " or " +
KMSRESTConstants.EEK_DECRYPT);
{code}
Please construct a string and log/throw the constructed string. Same applies to
{{decryptEncryptedKey}}.
> Add logs to KMS server-side to improve supportability
> -----------------------------------------------------
>
> Key: HADOOP-13317
> URL: https://issues.apache.org/jira/browse/HADOOP-13317
> Project: Hadoop Common
> Issue Type: Improvement
> Components: kms
> Reporter: Xiao Chen
> Assignee: Suraj Acharya
> Priority: Minor
> Labels: supportability
> Attachments: HADOOP-13317-1.patch, HADOOP-13317-2.patch,
> HADOOP-13317-3.patch, HADOOP-13317-3.patch, HADOOP-13317.patch
>
>
> [KMS.java|https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java]
> is the main class that serves KMS http requests. There're currently no logs
> at all, making trouble shooting difficult.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
