[
https://issues.apache.org/jira/browse/HADOOP-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chen Liang updated HADOOP-13658:
--------------------------------
Description:
In Hadoop Common, there are several places where the config keys are used by
the literal strings instead of their names as in configuration key classes. The
default values have the same issue. For example
{code:title=in o.a.h.i.f.t.Compression.java}
conf.setInt("io.compression.codec.lzo.buffersize", 64 * 1024);
{code}
should be
{code}
conf.setInt(
CommonConfigurationKeys.IO_COMPRESSION_CODEC_LZO_BUFFERSIZE_KEY,
CommonConfigurationKeys.IO_COMPRESSION_CODEC_LZO_BUFFERSIZE_DEFAULT);
{code}
instead
was:
In Hadoop Common, there are several places where the config keys are used by
the literal strings instead of their names as in configuration key classes. For
example
{code:title=in o.a.h.i.f.t.Compression.java}
conf.setInt("io.compression.codec.lzo.buffersize", 64 * 1024);
{code}
should be
{code}
conf.setInt(CommonConfigurationKeys.IO_COMPRESSION_CODEC_LZO_BUFFERSIZE_KEY, 64
* 1024);
{code}
instead
> Replace config key literal strings with config key names I: hadoop common
> -------------------------------------------------------------------------
>
> Key: HADOOP-13658
> URL: https://issues.apache.org/jira/browse/HADOOP-13658
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Reporter: Chen Liang
> Assignee: Chen Liang
> Priority: Minor
> Attachments: HADOOP-13658.001.patch, HADOOP-13658.002.patch
>
>
> In Hadoop Common, there are several places where the config keys are used by
> the literal strings instead of their names as in configuration key classes.
> The default values have the same issue. For example
> {code:title=in o.a.h.i.f.t.Compression.java}
> conf.setInt("io.compression.codec.lzo.buffersize", 64 * 1024);
> {code}
> should be
> {code}
> conf.setInt(
> CommonConfigurationKeys.IO_COMPRESSION_CODEC_LZO_BUFFERSIZE_KEY,
> CommonConfigurationKeys.IO_COMPRESSION_CODEC_LZO_BUFFERSIZE_DEFAULT);
> {code}
> instead
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
