[
https://issues.apache.org/jira/browse/HADOOP-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15527660#comment-15527660
]
Mingliang Liu commented on HADOOP-13658:
----------------------------------------
Can you use the static import if possible? That way the code will be shorter
without verbose line breaks like following:
{code}
212
conf.getInt(CommonConfigurationKeysPublic
213 .IO_FILE_BUFFER_SIZE_KEY,
214 CommonConfigurationKeysPublic
215
.IO_FILE_BUFFER_SIZE_DEFAULT));
{code}
Otherwise +1. Thanks.
> Replace config key literal strings with config key names I: hadoop common
> -------------------------------------------------------------------------
>
> Key: HADOOP-13658
> URL: https://issues.apache.org/jira/browse/HADOOP-13658
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Reporter: Chen Liang
> Assignee: Chen Liang
> Priority: Minor
> Attachments: HADOOP-13658.001.patch, HADOOP-13658.002.patch
>
>
> In Hadoop Common, there are several places where the config keys are used by
> the literal strings instead of their names as in configuration key classes.
> The default values have the same issue. For example
> {code:title=in o.a.h.i.f.t.Compression.java}
> conf.setInt("io.compression.codec.lzo.buffersize", 64 * 1024);
> {code}
> should be
> {code}
> conf.setInt(
> CommonConfigurationKeys.IO_COMPRESSION_CODEC_LZO_BUFFERSIZE_KEY,
> CommonConfigurationKeys.IO_COMPRESSION_CODEC_LZO_BUFFERSIZE_DEFAULT);
> {code}
> instead
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
