[
https://issues.apache.org/jira/browse/HADOOP-13667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549341#comment-15549341
]
Daniel Templeton commented on HADOOP-13667:
-------------------------------------------
Thanks for the patch. My only comment is no language. Instead of {code}# An
typical usage of tags is separating metrics for rpc port
# and service rpc port of HDFS.{code} it would be better as {code}# A typical
use of tags is separating the metrics by the HDFS rpc port
# and HDFS service rpc port.{code}
> Fix typing mistake of inline document in hadoop-metrics2.properties
> -------------------------------------------------------------------
>
> Key: HADOOP-13667
> URL: https://issues.apache.org/jira/browse/HADOOP-13667
> Project: Hadoop Common
> Issue Type: Improvement
> Components: documentation
> Reporter: Rui Gao
> Assignee: Rui Gao
> Attachments: HADOOP-13667.patch
>
>
> Fix typing mistake of inline document in hadoop-metrics2.properties.
> {code}#*.sink.ganglia.tagsForPrefix.jvm=ProcesName{code} should be
> {code}#*.sink.ganglia.tagsForPrefix.jvm=ProcessName{code}
> And also could add examples into the inline document for easier understanding
> of metrics tag related configuration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
