[
https://issues.apache.org/jira/browse/HADOOP-13522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551225#comment-15551225
]
Akira Ajisaka commented on HADOOP-13522:
----------------------------------------
Thank you for updating the patch!
bq. Though, the toShort again needs to be converted to octal.
My bad. Your new test case looks good. Now I have the following two comments.
* Would you rebase the patch for the latest trunk?
* Would you remove trailing whitespaces?
https://builds.apache.org/job/PreCommit-HADOOP-Build/10683/artifact/patchprocess/whitespace-eol.txt
bq. I can later expand the test case to include a match check against every
permutation of possible values.
Great! Let's do this in a separate jira after this issue.
> Permissions on fs stat added
> ----------------------------
>
> Key: HADOOP-13522
> URL: https://issues.apache.org/jira/browse/HADOOP-13522
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 3.0.0-alpha1
> Reporter: Alex Garbarini
> Assignee: Alex Garbarini
> Attachments: HADOOP-13522.001.patch, HADOOP-13522.002.patch,
> HADOOP-13522.003.patch, HADOOP-13522.004.patch, HADOOP-13522.005.patch,
> HADOOP-13522.006.patch, HADOOP-13522.007.patch
>
>
> This patch adds to fs/shell/Stat.java the missing options of %a and %A.
> FileStatus already contains the getPermission() method required for returning
> symbolic permissions. FsPermission contains the method to return the binary
> short, but nothing to present in standard Octal format.
> Most UNIX admins base their work on such standard octal permissions. Hence,
> this patch also introduces one tiny method to translate the toShort() return
> into octal.
> Build has already passed unit tests and javadoc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
