[
https://issues.apache.org/jira/browse/HADOOP-13697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mingliang Liu updated HADOOP-13697:
-----------------------------------
Attachment: HADOOP-13697.000.patch
Thanks [~jojochuang] for your prompt comment.
{quote}
The exception is already caught is main() and rethrown.
{quote}
I guess you're talking about {{Cli#run}} instead of {{main()}}? Please see the
v0 patch.
Another point is that, should we use ToolRunner to call the {{Cli#run()}}
instead of calling it directly? In that way, the ToolRunner can provided some
features like setting {{CallerContext}}, accepting
[Generic_Options|https://hadoop.apache.org/docs/r2.7.2/hadoop-project-dist/hadoop-common/CommandsManual.html#Generic_Options]
(do we plan to support that) in LogLevel?
> LogLevel#main throws exception if no arguments provided
> -------------------------------------------------------
>
> Key: HADOOP-13697
> URL: https://issues.apache.org/jira/browse/HADOOP-13697
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.9.0
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Attachments: HADOOP-13697.000.patch
>
>
> {code}
> root@b9ab37566005:/# hadoop daemonlog
> Usage: General options are:
> [-getlevel <host:port> <classname> [-protocol (http|https)]
> [-setlevel <host:port> <classname> <level> [-protocol (http|https)]
> Exception in thread "main" org.apache.hadoop.HadoopIllegalArgumentException:
> No arguments specified
> at org.apache.hadoop.log.LogLevel$CLI.parseArguments(LogLevel.java:138)
> at org.apache.hadoop.log.LogLevel$CLI.run(LogLevel.java:106)
> at org.apache.hadoop.log.LogLevel.main(LogLevel.java:70)
> {code}
> I think we can catch the exception in the main method, and dump a log error
> message instead of throw the stack which may frustrate users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
