[
https://issues.apache.org/jira/browse/HADOOP-13699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556739#comment-15556739
]
Xiao Chen commented on HADOOP-13699:
------------------------------------
Thanks for finding and fixing this Andrew. I'm +1 on the return-fast change,
and looking at HADOOP-6871 it's fixing a bug that's not considered in the
original implementation. Ideally we should let people from either jira comment,
in case they feel differently.
And man HADOOP-6871 is 4+ years ago. I hope no one has been waiting for that
for the past half-decade. :) Mind linking the jira (I didn't find a
{{replaces}} option, maybe {{supercedes}}?) and comment there, so this is
change is more advertised?
> Configuration does not substitute multiple references to the same var
> ---------------------------------------------------------------------
>
> Key: HADOOP-13699
> URL: https://issues.apache.org/jira/browse/HADOOP-13699
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 3.0.0-alpha1
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Priority: Critical
> Attachments: HADOOP-13699.001.patch
>
>
> Config var loop detection was originally introduced by HADOOP-6871. Due to
> cycle detection changes in the trunk patch for HADOOP-11506, resolution for
> multiple references to the same variable no longer resolved, e.g.
> {noformat}
> somekey = "${otherkey} ${otherkey}"
> {noformat}
> This loop detection business is fragile, expensive, and not in branch-2, so
> let's reduce it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
