[
https://issues.apache.org/jira/browse/HADOOP-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kai Zheng updated HADOOP-13641:
-------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Fix Version/s: 3.0.0-alpha2
2.8.0
Status: Resolved (was: Patch Available)
Thanks for the contribution, [~HuafengWang]. Committed to trunk, branch-2 and
branch-2.8
> Update UGI#spawnAutoRenewalThreadForUserCreds to reduce indentation
> -------------------------------------------------------------------
>
> Key: HADOOP-13641
> URL: https://issues.apache.org/jira/browse/HADOOP-13641
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Xiao Chen
> Assignee: Huafeng Wang
> Priority: Minor
> Labels: newbie
> Fix For: 2.8.0, 3.0.0-alpha2
>
> Attachments: HADOOP-13641-branch-2.01.patch, HADOOP-13641.1.patch,
> HADOOP-13641.2.patch
>
>
> From [~drankye]'s comment in HADOOP-13590:
> Could we return earlier at the beginning so we can avoid at least 2 level of
> indents and make the whole block more readable?
> {code}
> /**Spawn a thread to do periodic renewals of kerberos credentials*/
> private void spawnAutoRenewalThreadForUserCreds() {
> if (isSecurityEnabled()) {
> //spawn thread only if we have kerb credentials
> if (user.getAuthenticationMethod() == AuthenticationMethod.KERBEROS &&
> !isKeytab) {
> ...
> ...
> very deep nested ...
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
