[
https://issues.apache.org/jira/browse/HADOOP-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563645#comment-15563645
]
ASF GitHub Bot commented on HADOOP-12774:
-----------------------------------------
Github user cnauroth commented on a diff in the pull request:
https://github.com/apache/hadoop/pull/136#discussion_r82688403
--- Diff:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileStatus.java
---
@@ -32,18 +32,24 @@
@InterfaceStability.Evolving
public class S3AFileStatus extends FileStatus {
private boolean isEmptyDirectory;
+ private final String owner;
--- End diff --
I think we can achieve this change without adding a member variable in the
subclass. (See more specific notes to follow.) Removing this member variable
would reduce memory footprint. Admittedly, the memory cost is probably not
significant, but as we start thinking about the possibility of caching
`FileStatus` instances client-side for things like S3Guard, then the
per-instance memory cost of each `FileStatus` could become more significant.
> s3a should use UGI.getCurrentUser.getShortname() for username
> -------------------------------------------------------------
>
> Key: HADOOP-12774
> URL: https://issues.apache.org/jira/browse/HADOOP-12774
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 2.7.2
> Reporter: Steve Loughran
> Assignee: Steve Loughran
>
> S3a users {{System.getProperty("user.name")}} to get the username for the
> homedir. This is wrong, as it doesn't work on a YARN app where the identity
> is set by HADOOP_USER_NAME, or in a doAs clause.
> Obviously, {{UGI.getCurrentUser.getShortname()}} provides that name,
> everywhere.
> This is a simple change in the source, though testing is harder ... probably
> best to try in a doAs
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
