Manoj Govindassamy created HADOOP-13721:

             Summary: Remove stale method ViewFileSystem#getTrashCanLocation
                 Key: HADOOP-13721
             Project: Hadoop Common
          Issue Type: Bug
    Affects Versions: 3.0.0-alpha2
            Reporter: Manoj Govindassamy
            Assignee: Manoj Govindassamy
            Priority: Minor

{{ViewFileSystem}} which extends {{FileSystem}} has a public method 
{{getTrashCanLocation}} which is neither overridden nor used by anybody. Looks 
like it existed when the file was created, and also I see the implementation 
returning homeDirectory which might not be the expected one in cases of 
{{expunge}}. So, inclined to remove this stale and potentially dangerous method 
unless anyone has any concerns. 

  public Path getTrashCanLocation(final Path f) throws FileNotFoundException {
    final InodeTree.ResolveResult<FileSystem> res = 
      fsState.resolve(getUriPath(f), true);
    return res.isInternalDir() ? null : res.targetFileSystem.getHomeDirectory();

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to