Andrew Wang commented on HADOOP-13717:

Besides the Mover, I'd also include the new intra-DN balancer in the collection 
of special commands. It's currently not daemon-enabled.

I don't have strong opinions here, but it seems like if someone is not 
specifying the "--daemon" flag, then they don't care about daemon things like 
pid files and log dirs for stdout/stderr. The audit log is an interesting case, 
but I think app-specific logging should be checked in the app, not the shell 
scripts (which are generic).

I think some combination of a) and b) is appropriate.

Regarding a), I don't think the balancer is commonly run in the background; 
Bigtop and CDH don't have balancer init scripts for instance. So can remove 
daemonization, also for Mover if it has it.

Regarding b), I'd prefer to short-circuit to hadoop_java_exec, but b) is 
alright too. I think there should be some generic fix for when "--daemon" isn't 
specified, because of user expectations.

Happy to try a patch if you agree.

> Shell scripts call hadoop_verify_logdir even when command is not started as 
> daemon
> ----------------------------------------------------------------------------------
>                 Key: HADOOP-13717
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13717
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Andrew Wang
> Issue found when working with the HDFS balancer.
> In {{hadoop_daemon_handler}}, it calls {{hadoop_verify_logdir}} even for the 
> "default" case which calls {{hadoop_start_daemon}}. {{daemon_outfile}} which 
> specifies the log location isn't even used here, since the command is being 
> started in the foreground.
> I think we can push the {{hadoop_verify_logdir}} call down into 
> {{hadoop_start_daemon_wrapper}} instead, which does use the outfile.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to