Eric Badger updated HADOOP-13709:
    Attachment: HADOOP-13709.002.patch

Attaching new patch that uses a shutdown hook to kill the child process that 
was spawned by shell. I tested this on a local cluster on the localizer use 
case from YARN-5641. I replaced the {{untar}} process with a {{sleep 1000000}} 
process and confirmed that the {{sleep}} was killed immediately after the 
localizer. Before this patch, the localizer would shutdown without killing the 
{{sleep}} process. 

 [~jlowe], [~daryn], please review

> Clean up subprocesses spawned by Shell.java:runCommand when the shell process 
> exits
> -----------------------------------------------------------------------------------
>                 Key: HADOOP-13709
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13709
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.2.0
>            Reporter: Eric Badger
>            Assignee: Eric Badger
>         Attachments: HADOOP-13709.001.patch, HADOOP-13709.002.patch
> The runCommand code in Shell.java can get into a situation where it will 
> ignore InterruptedExceptions and refuse to shutdown due to being in I/O 
> waiting for the return value of the subprocess that was spawned. We need to 
> allow for the subprocess to be interrupted and killed when the shell process 
> gets killed. Currently the JVM will shutdown and all of the subprocesses will 
> be orphaned and not killed.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to