Andrew Wang commented on HADOOP-13722:

I bet precommit bot is going to have a field day with the VFS code :) you can 
tell it predates checkstyle turned on in precommit.

I see a few other small nits we could address:

* Unnecessary "static" on ResultKind, I think we should also have a newline 
after the closing brace of this enum.
* Erratic indentation still on the getTargetFileSystem overrides
* TestViewFsConfig, indentation of the "new InodeTree" is off, maybe run the 
auto-formatter on this entire file.
* ViewFileSystem#MountPoint, want to turn those slash comments into javadoc 

> Code cleanup -- ViewFileSystem and InodeTree
> --------------------------------------------
>                 Key: HADOOP-13722
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13722
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Manoj Govindassamy
>            Assignee: Manoj Govindassamy
>            Priority: Minor
>         Attachments: HADOOP-13722.01.patch
> ViewFileSystem is the FileSystem for viewfs:// and its uses InodeTree to 
> manage the mount points. These files being very old, don't quit adhere to the 
> styling and coding standards. Will do code cleanup of these files as part of 
> this jira. No new functionalities or tests will be added as part of this 
> jira. 

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to