[
https://issues.apache.org/jira/browse/HADOOP-12984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582864#comment-15582864
]
Xiaoyu Yao edited comment on HADOOP-12984 at 10/17/16 5:36 PM:
---------------------------------------------------------------
Propose to port this along with HDFS-10256 to branch-2.8. The cherry-pick is
mostly clean with only few imports adjustment.
RollingFileSystemSinkTestBase.java is removed as RollingFileSystemSink does not
existing in branch-2.8.
Below is a complete list of conflicts, I will post the branch-2.8 patch.
[~ste...@apache.org], can you help review?
{code}
both modified:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/key/TestKeyShell.java
both modified:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFileSystem.java
both modified:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java
deleted by us:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/sink/RollingFileSystemSinkTestBase.java
both modified:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestLdapGroupsMapping.java
both modified:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/alias/TestCredShell.java
both modified:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/ssl/TestReloadingX509TrustManager.java
{code}
was (Author: xyao):
Propose to port this along with HDFS-9263 to branch-2.8. The cherry-pick is
mostly clean with only few imports adjustment.
RollingFileSystemSinkTestBase.java is removed as RollingFileSystemSink does not
existing in branch-2.8.
Below is a complete list of conflicts, I will post the branch-2.8 patch.
[~ste...@apache.org], can you help review?
{code}
both modified:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/key/TestKeyShell.java
both modified:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFileSystem.java
both modified:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java
deleted by us:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/sink/RollingFileSystemSinkTestBase.java
both modified:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestLdapGroupsMapping.java
both modified:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/alias/TestCredShell.java
both modified:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/ssl/TestReloadingX509TrustManager.java
{code}
> Add GenericTestUtils.getTestDir method and use it for temporary directory in
> tests
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-12984
> URL: https://issues.apache.org/jira/browse/HADOOP-12984
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Affects Versions: 3.0.0-alpha1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Fix For: 2.9.0, 3.0.0-alpha1
>
> Attachments: HADOOP-12984-003.patch,
> HADOOP-12984.branch-2.8.00.patch, HDFS-9263-001.patch, HDFS-9263-002.patch,
> HDFS-9263-003.patch
>
>
> We have seen some tests had been used the path {{test/build/data}} to store
> files, so leaking files which fail the new post-build RAT test checks on
> Jenkins (and dirtying all development systems with paths which {{mvn clean}}
> will miss.
> In order not to occur these bugs such as MAPREDUCE-6589 and HDFS-9571 again,
> we'd like to introduce new utility methods to get a temporary directory path
> easily, and use the methods in tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
