[
https://issues.apache.org/jira/browse/HADOOP-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971395#action_12971395
]
Hadoop QA commented on HADOOP-6298:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12466240/h-6298.patch
against trunk revision 1044755.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/139//testReport/
Findbugs warnings:
https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/139//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/139//console
This message is automatically generated.
> BytesWritable#getBytes is a bad name that leads to programming mistakes
> -----------------------------------------------------------------------
>
> Key: HADOOP-6298
> URL: https://issues.apache.org/jira/browse/HADOOP-6298
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.20.1
> Reporter: Nathan Marz
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: h-6298.patch
>
>
> Pretty much everyone at Rapleaf who has worked with Hadoop has misused
> BytesWritable#getBytes at some point, not expecting the byte array to be
> padded. I think we can completely alleviate these programming mistakes by
> deprecating and renaming this method (again) to be more descriptive. I
> propose "getPaddedBytes()" or "getPaddedValue()". It would also be helpful to
> have a helper method "getNonPaddedValue()" that makes a copy into a
> non-padded byte array.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
